Audio: add CTC to PTL rt5682 path.#10696
Conversation
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-tas2563-rt5682-dax.bin,SPK_ID=6,DEEPBUFFER_FW_DMA_MS=10,\ | ||
| INCLUDE_ECHO_REF=true,BT_NAME=SSP2-BT,BT_ID=7,BT_PCM_NAME=Bluetooth,DEEP_BUF_SPK=true,\ | ||
| PLAYBACK_PIPELINE_SRC=dax,DOLBY_DAX_CORE_ID=0" | ||
| "cavs-rt5682-dax-ctc\;sof-ptl-tas2563-rt5682-dax-ctc\;PLATFORM=ptl,NUM_DMICS=2,DMIC0_PCM_ID=99,\ |
There was a problem hiding this comment.
you should keep using "cavs-rt5682.conf". The variation can be handled by argument e.g. USE_CTC_SPK=true
There was a problem hiding this comment.
I refined the whole PR and added USE_CTC_SPK to switch the CTC.
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Looks good, just the opens already mentioned.
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
1d53704 to
63efc72
Compare
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
There a lot of change here including in common files, can you add more context in the commit message especially around the changes in any common files.
Include CTC component in PTL with rt5682. Introduce `USE_CTC_SPK` in `cavs-mixin-mixout-ctc-ssp.conf` and `cavs-mixin-mixout-dax-ssp.conf` to conditionally include CTC component in the pipeline. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
63efc72 to
c74ac5a
Compare
|
Added more details in the commit message now. Thanks! |
| stream_name "$HEADSET_CODEC_NAME" | ||
| node_type $I2S_LINK_OUTPUT_CLASS | ||
| } | ||
| IncludeByKey.USE_CTC_SPK { |
There was a problem hiding this comment.
Do we need to have this in cavs-mixin-mixout-ctc-ssp.conf given we already have cavs-mixin-mixout-ssp.conf for no CTC case?
| sink "dai-copier.SSP.$HEADSET_CODEC_NAME.playback" | ||
| } | ||
| { | ||
| source "dai-copier.SSP.$HEADSET_CODEC_NAME.capture" |
There was a problem hiding this comment.
why do we have the routing for capture here?
3 participants
Include CTC component in PTL with rt5682.